Re: [PR] feat: Support murmur3_hash and sha2 family hash functions [datafusion-comet]

[via GitHub]

advancedxy commented on code in PR #226:
URL: https://github.com/apache/datafusion-comet/pull/226#discussion_r1576529455


##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -983,8 +983,7 @@ class CometExpressionSuite extends CometTestBase with 
AdaptiveSparkPlanHelper {
     }
   }
 
-  // TODO: enable this when we add md5 function to Comet
-  ignore("md5") {
+  test("md5") {

Review Comment:
   > is md5 function working?
   
   I manually checked with the web ui and the unit test passes:
   
![image](https://github.com/apache/datafusion-comet/assets/807537/06e18962-e957-456f-bf2d-a3bdbd8b0c73)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org