Banyc commented on code in PR #20229:
URL: https://github.com/apache/datafusion/pull/20229#discussion_r2781658695
##########
datafusion/expr/src/sort_options.rs:
##########
@@ -0,0 +1,50 @@
+use arrow::compute::SortOptions as ArrowSortOptions;
+
+/// Options for sorting.
+///
+/// This struct implements a builder pattern for creating `SortOptions`.
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
+pub struct SortOptions {
+ pub descending: bool,
+ pub nulls_first: bool,
+}
+
+impl SortOptions {
+ /// Create a new `SortOptions` with default values (Ascending, Nulls Last).
+ pub fn new() -> Self {
+ Self::default()
+ }
Review Comment:
dangerous; this is again hiding information from use sites; clankers can
never understand the idea, other than copy-and-pasting the training data 80% of
which is a bunch of
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
