adriangb commented on code in PR #20229: URL: https://github.com/apache/datafusion/pull/20229#discussion_r2792895104
########## datafusion/expr/src/sort_options.rs: ########## @@ -0,0 +1,53 @@ +use arrow::compute::SortOptions as ArrowSortOptions; + +/// Options for sorting. +/// +/// This struct implements a builder pattern for creating `SortOptions`. +#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)] Review Comment: @Sahitya0805 I think we should use the existing struct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
