alamb commented on code in PR #20229: URL: https://github.com/apache/datafusion/pull/20229#discussion_r2788459896
########## datafusion/core/tests/repro_sort_api.rs: ########## @@ -0,0 +1,32 @@ +use datafusion::prelude::*; Review Comment: I am not sure we need to add an entirely new end to end integration test -- is it not possible to add these tests to one of the existing modules? Perhaps doctests woudl be useful ########## datafusion/expr/src/sort_options.rs: ########## @@ -0,0 +1,53 @@ +use arrow::compute::SortOptions as ArrowSortOptions; + +/// Options for sorting. +/// +/// This struct implements a builder pattern for creating `SortOptions`. +#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)] Review Comment: How is this different than https://docs.rs/arrow/latest/arrow/compute/struct.SortOptions.html ? It seems like basically the exact same thing 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
