Sahitya0805 commented on PR #20229: URL: https://github.com/apache/datafusion/pull/20229#issuecomment-3883504792
Sorry about the previous issues! I have updated the code to fix everything you mentioned: - **Explicit Values**: I changed [new()](cci:1://file:///Users/sahityasingh/datafusion/datafusion/expr/src/sort_options.rs:29:4-48:5) to use clear values instead of defaults. - **Better Performance**: I made the functions `const` and `inline` so they are faster. - **cleaner Tests**: I moved the tests into the main file and deleted the extra test file. - **Fixes**: I added the license header and fixed all the formatting. Please let me know if this looks better! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
