adriangb commented on PR #20229: URL: https://github.com/apache/datafusion/pull/20229#issuecomment-3875128943
> * my concrete suggestion on this part is "this is again hiding information from use sites" Personally I don't think this suggestion is helpful. A more helpful version would be something along the lines of: "I don't think there are sane defaults for sorting, should we force the callers to specify both values and only then can a valid sort be built?" I think this is what you mean but to be honest I am not sure. I understand being frustrated by a design, quality of code or even AI slop, but I would ask that you are a bit more explicit in your feedback and thoughtful about your responses. Comments like https://github.com/apache/datafusion/pull/20229#issuecomment-3872344536 are not helpful or constructive, even if it is an AI on the other side. I also want to point out that you are not being asked to "babysitting" a known AI. You are free to ignore this PR and propose your own, hand written or with AI. But if you do choose to engage in this PR or any other review please be thoughtful about your feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
