Banyc commented on PR #20229:
URL: https://github.com/apache/datafusion/pull/20229#issuecomment-3875095005
@adriangb
- I am upset by the poor code quality here:
```rust
// my comment for this: ...this is again hiding information from use
sites...
pub fn new() -> Self {
Self::default()
}
```
to
```rust
pub fn new() -> Self {
Self {
descending: false,
nulls_first: false,
}
}
```
- You are contributor here, and you know the AI pretended to fix it.
- I am upset by the "poor code quality", not by the nature of AI (but AI
tends to produce slop, being a confounding variable to the poorliness).
- I am not a prompt engineer myself so I don't think I have the
responsibility to correct the PR. It is not my PR after all. Therefore I am the
commenter in this PR. BTW, babysitting a known AI to get it right takes more
time and energy to fix it than you just write it yourself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
