jayzhan211 commented on code in PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#discussion_r1769690622
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -89,7 +91,7 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single value
- Scalar(ScalarValue),
+ Scalar(Scalar),
Review Comment:
I think it is hard to tell the role given we are in the intermediate state.
I would said all of `ColumnarValue` and `ScalarValue` and `Scalar` are physical
types now, given they have either `ArrayRef` or `DataType`
The end state in my mind is that,
`ColumnarValue` stores `ArrayRef` for multiple rows and `ScalarValue` for
single rows case. `ScalarValue` has either native type like `i64` or
`arrow::Scalar`.
We will have `LogicalType` which could be resolved from `DataType` given the
mapping we determined, which should be customizable as well for user defined
type. Similar to the role `Scalar` in this PR, which record the relationship
between `ScalarValue` to `DataType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
