jayzhan211 commented on code in PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#discussion_r1769691504
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -89,7 +91,7 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single value
- Scalar(ScalarValue),
+ Scalar(Scalar),
Review Comment:
> remove variants of ScalarValue while still accounting for them via
data_type
Our first step is to minimize the variant of types, so we don't need
`ScalarValue::Utf8`, `ScalarValue::LargeUtf8` any more but `Scalar` which has
`ScalarValue::String` + `DataType::Utf8` or `ScalarValue::String` +
`DataType::LargeUtf8`. We determine the actual `physical type` based on arrow's
DataType. `ScalarValue::String` is then something close to `logical type`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
