iffyio commented on code in PR #1435:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1806011009
##########
src/ast/mod.rs:
##########
@@ -156,6 +179,30 @@ impl Ident {
Ident {
value: value.into(),
quote_style: Some(quote),
+ span: Span::empty(),
+ }
+ }
+
+ pub fn with_span<S>(span: Span, value: S) -> Self
+ where
+ S: Into<String>,
+ {
+ Ident {
+ value: value.into(),
+ quote_style: None,
+ span,
+ }
+ }
+
+ pub fn with_quote_and_span<S>(quote: char, span: Span, value: S) -> Self
+ where
+ S: Into<String>,
+ {
+ assert!(quote == '\'' || quote == '"' || quote == '`' || quote == '[');
Review Comment:
Ah I didn't realise the behavior exists already, it sounds reasonable to
follow suit. The current behavior feels unusual to me though, and I agree that
it'd be out of scope for this PR to change it. I can take a closer look at it
and we can have the behavior here match the outcome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
