Nyrox commented on code in PR #1435:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1802748188
##########
src/ast/mod.rs:
##########
@@ -156,6 +179,30 @@ impl Ident {
Ident {
value: value.into(),
quote_style: Some(quote),
+ span: Span::empty(),
+ }
+ }
+
+ pub fn with_span<S>(span: Span, value: S) -> Self
+ where
+ S: Into<String>,
+ {
+ Ident {
+ value: value.into(),
+ quote_style: None,
+ span,
+ }
+ }
+
+ pub fn with_quote_and_span<S>(quote: char, span: Span, value: S) -> Self
+ where
+ S: Into<String>,
+ {
+ assert!(quote == '\'' || quote == '"' || quote == '`' || quote == '[');
Review Comment:
What's the verdict here? Remove or not? :P I am not sure it's in the scope
of this PR tbh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
