Nyrox commented on code in PR #1435:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1802382748
##########
tests/sqlparser_common.rs:
##########
@@ -9805,6 +9853,7 @@ fn parse_map_access_expr() {
#[test]
fn parse_connect_by() {
let expect_query = Select {
+ select_token: TokenWithLocation::wrap(Token::make_keyword("SELECT")),
Review Comment:
Hmm yeah. I mean "Token" in most of these cases is going to be Keyword, so
there is some certainty to them being predictable. I.e. if two queries have
different tokens, I would very much expect them to actually be different
queries.
But I also get if it opens too many cans of worms, so we could just omit it
from the trait implementations again, it's just a bit annoying then that we
would have to start writing custom implementations for every type that is
storing a Token.
The Token is useful, because you need to store it (or a at least it's Span)
so you can include it for reported spans.
I.e. `select a from b`, if you don't store the token for 'select' can't
include that as part of it's span :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
