lovasoa commented on code in PR #1435:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1806173730
##########
src/ast/spans.rs:
##########
@@ -40,28 +41,85 @@ pub trait Spanned {
impl Spanned for Query {
fn span(&self) -> Span {
- self.body
- .span()
- .union_opt(&self.with.as_ref().map(|i| i.span()))
+ let Query {
+ with,
+ body,
+ order_by,
+ limit,
+ limit_by,
+ offset,
+ fetch,
+ locks: _, // todo
+ for_clause: _, // todo, mysql specific
Review Comment:
@Nyrox : `for_clause` is specific to microsoft sql server (mssql), not mysql
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
