iffyio commented on code in PR #1435:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1806016492
##########
tests/sqlparser_common.rs:
##########
@@ -9805,6 +9853,7 @@ fn parse_map_access_expr() {
#[test]
fn parse_connect_by() {
let expect_query = Select {
+ select_token: TokenWithLocation::wrap(Token::make_keyword("SELECT")),
Review Comment:
Yeah I agree it can become unweildy to try to workaround this by needing
custom impls for each type, also as you mention its probably a reasonable
assumption that the queries are different if they have different tokens (given
that they come from the same parser)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
