alamb commented on code in PR #13663:
URL: https://github.com/apache/datafusion/pull/13663#discussion_r1887364957
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -1777,6 +1777,8 @@ fn round_trip_datatype() {
}
}
+// TODO file a ticket about handling deprecated dict_id attributes
+#[allow(deprecated)]
Review Comment:
I don't know what to do here:
1. Should we remove the `field_id` from DataFusion serialization code (as it
is planned for removal eventually in DataFusion)?
2. Should we un-deprecate `field_id` in arrow-rs?
3. Something else?
@avantgardnerio, @thinkharderdev and @Dandandan , this test was added in
- https://github.com/apache/datafusion/pull/8457
However, @brancz's upstream PR in arrow-rs has deprecated `dict_id` on
`Field` and all related APIs with the idea it will be eventually removed (and
become a detail of the IPC transport rather than visible in the Schema)
- https://github.com/apache/arrow-rs/pull/6873 upstream in arrow-rs
@thinkharderdev mentioned
https://github.com/apache/arrow-rs/pull/6873#issuecomment-2543132904
> If people are using the dictionary ID it's probably for something that
should properly be done with kv metadata instead.
So one possibility could be to provide some more documentation / writeup as
an upgrade guide for arrow explaining how to use field metadata instead ?
Please advise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
