thinkharderdev commented on code in PR #13663:
URL: https://github.com/apache/datafusion/pull/13663#discussion_r1887619206
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -1777,6 +1777,8 @@ fn round_trip_datatype() {
}
}
+// TODO file a ticket about handling deprecated dict_id attributes
+#[allow(deprecated)]
Review Comment:
> If people are using the dictionary ID it's probably for something that
should properly be done with kv metadata instead
I mostly meant that if you give people 32 bits of space someone, somewhere
will use it as metadata if they don't need it for anything else. I don't really
have any particular use case in mind.
I don't have any objection to removing the field from datafusion serde. When
we added that test we were still fighting to try and ensure unique dict IDs but
we've long since moved on and found better ways around it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
