brancz commented on code in PR #13663:
URL: https://github.com/apache/datafusion/pull/13663#discussion_r1888266304
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -1777,6 +1777,8 @@ fn round_trip_datatype() {
}
}
+// TODO file a ticket about handling deprecated dict_id attributes
+#[allow(deprecated)]
Review Comment:
Agreed. Also,
https://github.com/apache/datafusion/pull/8457#issuecomment-1845770442 suggests
it was never important to set the dict id directly, just that it wasn't sent
correctly on the wire and already called out what to do once we remove the dict
id. There were in fact a [number](https://github.com/apache/arrow-rs/pull/6399)
of [dict](https://github.com/apache/arrow-rs/pull/6444)
[fixes](https://github.com/apache/arrow-rs/pull/6711) that were necessary for
us to correctly communicate the dicts correctly over the wire as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
