andygrove commented on code in PR #2604:
URL: https://github.com/apache/datafusion-comet/pull/2604#discussion_r2449534383


##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -3204,4 +3204,15 @@ class CometExpressionSuite extends CometTestBase with 
AdaptiveSparkPlanHelper {
     }
   }
 
+  test("test concat function - strings") {

Review Comment:
   Concat supports other types as well:
   
   ```scala
   private def allowedTypes: Seq[AbstractDataType] = Seq(StringType, 
BinaryType, ArrayType)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to