JosiahWI commented on code in PR #12201:
URL: https://github.com/apache/trafficserver/pull/12201#discussion_r2283670572


##########
src/traffic_layout/info.cc:
##########
@@ -91,6 +95,11 @@ produce_features(bool json)
 #else
   print_feature("TS_HAS_BROTLI", 0, json);
 #endif
+#if HAVE_ZSTD_H
+  print_feature("TS_HAS_ZSTD", 1, json);
+#else
+  print_feature("TS_HAS_ZSTD", 0, json);
+#endif

Review Comment:
   ```suggestion
   #ifdef HAVE_ZSTD_H
     print_feature("TS_HAS_ZSTD", 1, json);
   #else
     print_feature("TS_HAS_ZSTD", 0, json);
   #endif
   ```



##########
src/traffic_layout/info.cc:
##########
@@ -203,6 +212,11 @@ produce_versions(bool json)
 #else
   print_var("brotli", undef, json);
 #endif
+#if HAVE_ZSTD_H
+  print_var("zstd", LBW().print("{}", ZSTD_versionString()).view(), json);
+#else
+  print_var("zstd", undef, json);
+#endif

Review Comment:
   ```suggestion
   #ifdef HAVE_ZSTD_H
     print_var("zstd", LBW().print("{}", ZSTD_versionString()).view(), json);
   #else
     print_var("zstd", undef, json);
   #endif
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to