JakeChampion commented on code in PR #12201: URL: https://github.com/apache/trafficserver/pull/12201#discussion_r2284387289
########## plugins/compress/compress.cc: ########## @@ -136,8 +132,15 @@ handle_range_request(TSMBuffer req_buf, TSMLoc req_loc, HostConfiguration *hc) } } // namespace +// Forward declarations for ZSTD compression functions +#if HAVE_ZSTD_H +static void zstd_compress_init(Data *data); +static void zstd_compress_finish(Data *data); +static void zstd_compress_one(Data *data, const char *upstream_buffer, int64_t upstream_length); Review Comment: It looks to be a convention used in this plugin (which I seemed to have half followed...) These exist: - gzip_transform_one - gzip_transform_finish - brotli_transform_one - brotli_transform_finish - brotli_compress_operation Perhaps I should rename the zstd function to - zstd_transform_init - zstd_transform_finish - zstd_transform_one what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
