JosiahWI commented on code in PR #12201: URL: https://github.com/apache/trafficserver/pull/12201#discussion_r2284925830
########## plugins/compress/compress.cc: ########## @@ -136,8 +132,15 @@ handle_range_request(TSMBuffer req_buf, TSMLoc req_loc, HostConfiguration *hc) } } // namespace +// Forward declarations for ZSTD compression functions +#if HAVE_ZSTD_H +static void zstd_compress_init(Data *data); +static void zstd_compress_finish(Data *data); +static void zstd_compress_one(Data *data, const char *upstream_buffer, int64_t upstream_length); Review Comment: Following the local convention is good. I think going with the transform language is a great idea for consistency with the rest of the plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
