no problem, Code::Blocks supports both, here is the new patch without CRLF
line ending.

hm..currently, I don't have environment for cario and openGL and I know
little about them, so I make modifications in sdl-agg only and left empty
implementation in cario and ogl. Of course _validbounds and _drawbounds
should be thrown into SdlGlue class if the same thing in sdl-cario and
sdl-ogl are implemented..


2009/5/18 strk <s...@keybit.net>

> On Sun, May 17, 2009 at 06:55:40PM +0800, Wei Cao wrote:
> > sorry, I forgot to set _validbounds in the patch. here is the new patch.
>
> Does it make sense for _validbounds and _drawbounds to be in the
> base SdlGlue class rather than SdlAggGlue ?
>
> Also, your patch contains namy lines in which only line-ending
> (from unix to windows) change. Could you clean that up for readibility
> sake ? Thanks a lot.
>
> --strk;
>
>
> > 2009/5/16 Wei Cao <cyg....@gmail.com>
> >
> > > Sorry, I don't know how to send the patch to bzr repository.
> > >
> > > Instead, I make a patch via bzr diff, is that enough? Laugh, this is my
> > > first time to use bzr.
> > >
> > > The hack on agg renderer is not stable now, I think I would spend more
> time
> > > on it before I contribute it.
> > > 2009/5/15 strk <s...@keybit.net>
> > >
> > >  On Wed, May 06, 2009 at 01:55:13AM +0800, Wei Cao wrote:
> > >>
> > >> > I read gnash's source, and added a setInvalidatedRegions call in
> SDLGui,
> > >> to
> > >> > set invalidated regions in the renderer after movie_root::advance(),
> > >> before
> > >> > movie_root::display(). That helps a lot, but performance is still
> not
> > >> > satisfied.
> > >>
> > >> Would you mind contributing your patch to SDL gui ?
> > >>
> > >> --strk;
> > >>
> > >>  Free GIS & Flash consultant/developer      ()  ASCII Ribbon Campaign
> > >>  http://foo.keybit.net/~strk/services.html  /\  Keep it simple!
> > >>
> > >
> > >
>
>
> > _______________________________________________
> > Gnash-dev mailing list
> > Gnash-dev@gnu.org
> > http://lists.gnu.org/mailman/listinfo/gnash-dev
>
>
> --
>
>  Free GIS & Flash consultant/developer      ()  ASCII Ribbon Campaign
>  http://foo.keybit.net/~strk/services.html  /\  Keep it simple!
>

Attachment: improve_sdl_agg.patch
Description: Binary data

_______________________________________________
Gnash-dev mailing list
Gnash-dev@gnu.org
http://lists.gnu.org/mailman/listinfo/gnash-dev

Reply via email to