Comment #10 on issue 1650 by takao.fujiwara1: Fix some build warnings and errors
http://code.google.com/p/ibus/issues/detail?id=1650

The same workaround (to protect the g_type_init() call with a preprocessor check) is used in several other places in the ibus code, so it seems valid.

However I meant '#undef g_type_init' would be a kind of the workarounds since vala outputs g_type_init.

Note that the required gnome-common m4 files will be included in the tarball (inside aclocal.m4)

Right. However I thought some build users could run aclocal & autoconf directly without autogen.sh.

Probably I think the patch depends on how the GCC options are important.
I'm not sure about GNOME_COMPILE_WARNINGS([maximum]). If all GCC options are recommended by GNOME, maybe it's better to integrate the patch. I could not find GNOME_COMPILE_WARNINGS in https://wiki.gnome.org/GnomeGoals .

fixing some of the prototypes for functions with no arguments to have a "void" argument instead will change ABI ("Fix gcc strict-prototypes warnings"),

Does that change ABI? I guess the binaries can be swapped with/without "void".

Personally I think your original problem can be fixed with 'env CFLAGS=foo ./autogen.sh" until vala warnings will be fixed but I'm interested in the GNOME recommendations.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
--
You received this message because you are subscribed to the Google
Groups "ibus-devel" group.
iBus project web page: http://code.google.com/p/ibus/
iBus dev group: http://groups.google.com/group/ibus-devel?hl=en
--- You received this message because you are subscribed to the Google Groups "ibus-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

回复