On 03/05/2018 11:06 AM, Steve Saunders (CableLabs) wrote: > Here is how 1.3 behaves with respect to .dat files. > > > ------------------------------------------------------------------ > The build does not generate any new .dat files as far as I can tell (i.e. > json2cbor not run at build). > * Since no new .dat files are created in the src tree, they don’t show up as > modified with git status > > The build does copy over .dat files from the src locations to the destination > location (out/…) > * This places proper .dat files in the samples directories etc. > > It is assumed that developers will keep the .dat files up to date with the > corresponding .json files, and commit them. > ---------------------- > > Somethings is different between 1.3 builds vs. current master RE generating > .dat files during build. > > The 1.3 approach seemed to work pretty well to me (i.e. don’t generate .dat > files during the build). As it is now, you have to re-checkout all the > generated .dat files so they don’t get caught up in your commits. > > Kind Regards > Steve
yup, you're right, the 1.3-rel build does not attempt to regen the .dat files. the principle is the same as with the aggressive warnings (fail-on-warn): for developers of iotivity who are not racing to produce a product (and thus, working in master), make them pay attention to details - having the dat files out of date and not regenerated is arguably wrong, and nobody will notice that when working in the 1.3-rel tree at the moment. I don't say one way is better than the other, they're just different approaches, the project is free to change their mind on these, it's just the way it got set up during (relatively) recent rounds of changes. Really, we should get to a point where they don't need to be checked-in in git at all, and just always generated during the build, but as noted that can't be the case right now because of cross-building. _______________________________________________ iotivity-dev mailing list iotivity-dev@lists.iotivity.org https://lists.iotivity.org/mailman/listinfo/iotivity-dev
