[
https://issues.apache.org/jira/browse/ARTEMIS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217182#comment-16217182
]
ASF GitHub Bot commented on ARTEMIS-1476:
-----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1605
@michaelandrepearce
> To mitigate this concern, have we an ability to validate the result is
the same before and after this change? e.g. some sort of test?
Right now the calculation of the timeout isn't changed at all while the
test methodology (and the output of course) is changed only if `--verbose` is
specified: it is always possible to "validate" the output (the output
percentiles) turning off `--verbose` to see if the timeout estimation is
changed/different.
AFAIK the initial journal tuning is performed without `--verbose` hence I'm
expecting that nothing will change from the original version.
The other improvements (without affecting the no `--verbose` logic) are
made to help the JIT to avoid OSR in order to get more reliable results when
benchmarking vs temporary filesystem/very high speed devices/no fsync involved.
> HdrHistogram support on verbose SyncCalculation
> -----------------------------------------------
>
> Key: ARTEMIS-1476
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1476
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
>
> The SyncCalculation::syncTest could benefit of
> [HdrHistogram|http://hdrhistogram.org/] support to represent the write
> latencies percentile distribution while using it as a CLI command (ie through
> the perf-journal command).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
