[
https://issues.apache.org/jira/browse/ARTEMIS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217549#comment-16217549
]
ASF GitHub Bot commented on ARTEMIS-1476:
-----------------------------------------
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146671299
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/SyncCalculation.java
---
@@ -54,92 +172,94 @@ public static long syncTest(File datafolder,
String fileName,
int maxAIO,
JournalType journalType) throws Exception {
- SequentialFileFactory factory = newFactory(datafolder, fsync,
journalType, blockSize * blocks, maxAIO);
-
+ final Supplier<? extends SyncIOCompletion> ioCallbackFactory;
--- End diff --
For me trying to understand the code just for a review and understand the
differences/changes right now is a bit hard, as too much has moved, its not
impossible just is making it tricky to be sure.
If you're not too much against it, it might be easier to do the "if", then
it is simply cleaner / easier from a review POV to see what is changed / get
comfortable that actually the old behaviour is as is.
Then anyhow as we get more confident it might the if statement always
equates to true anyhow and the other side of the if block is removed entirely.
> HdrHistogram support on verbose SyncCalculation
> -----------------------------------------------
>
> Key: ARTEMIS-1476
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1476
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
>
> The SyncCalculation::syncTest could benefit of
> [HdrHistogram|http://hdrhistogram.org/] support to represent the write
> latencies percentile distribution while using it as a CLI command (ie through
> the perf-journal command).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
