[
https://issues.apache.org/jira/browse/ARTEMIS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219266#comment-16219266
]
ASF GitHub Bot commented on ARTEMIS-1476:
-----------------------------------------
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1605
I want to -1 this commit @franz1981..This is supposed to be a dumb piece of
code.. write at garbage free.
For instance.. I told you to use the same buffer, and the same Completion
over and over.. like it was before. There's not guarantees about the ordering
won't be changed... trusting that just makes it more fragile.
If you just added the Histogram like you said you would.. it would be one
thing.. but this logic is completely changed.. and I had spent a lot of time to
make sure about these calculations, using different hardwares (disk types).
> HdrHistogram support on verbose SyncCalculation
> -----------------------------------------------
>
> Key: ARTEMIS-1476
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1476
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
>
> The SyncCalculation::syncTest could benefit of
> [HdrHistogram|http://hdrhistogram.org/] support to represent the write
> latencies percentile distribution while using it as a CLI command (ie through
> the perf-journal command).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
