[
https://issues.apache.org/jira/browse/ARTEMIS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219373#comment-16219373
]
ASF GitHub Bot commented on ARTEMIS-1476:
-----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1605
@clebertsuconic
> This is supposed to be a dumb piece of code.. making IO writes at garbage
free.
And in the not verbose case it is garbage free as it was originally :)
Please use the latest commit to see it.
> For instance.. I told you to use the same buffer, and the same Completion
over and over.. like it was before.
In the not verbose case I've reused the buffer and the IOCompletion while
in the verbose case only the buffer, because I haven't found a way to maintain
for each write operation its own start time: if you see a better way to do that
please help me to understand it :+1:
> If you just added the Histogram like you said you would.. it would be one
thing.. but this logic is completely changed.. and I had spent a lot of time to
make sure about these calculations, using different hardwares (disk types).
And it is the reason why I'm providing a new commit that split the 2 logic
in a clean way in order to maintain the original 1:1 as it is (tiny bugs
included).
Let me know if it is ok @michaelandrepearce too in order to have 6 eyes on
it :+1:
> HdrHistogram support on verbose SyncCalculation
> -----------------------------------------------
>
> Key: ARTEMIS-1476
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1476
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
>
> The SyncCalculation::syncTest could benefit of
> [HdrHistogram|http://hdrhistogram.org/] support to represent the write
> latencies percentile distribution while using it as a CLI command (ie through
> the perf-journal command).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
