[
https://issues.apache.org/jira/browse/ARTEMIS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217231#comment-16217231
]
ASF GitHub Bot commented on ARTEMIS-1476:
-----------------------------------------
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146623554
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/SyncCalculation.java
---
@@ -54,92 +172,94 @@ public static long syncTest(File datafolder,
String fileName,
int maxAIO,
JournalType journalType) throws Exception {
- SequentialFileFactory factory = newFactory(datafolder, fsync,
journalType, blockSize * blocks, maxAIO);
-
+ final Supplier<? extends SyncIOCompletion> ioCallbackFactory;
--- End diff --
TBH I've provided a couple of fixes too :P: like the one on the file size
with `alignment != 1`.
I've tried to have a common logic while grouping the differences in order
to have a simpler and maintainable code: probably that's the reason why you are
seeing such differences on the source code.
I've already evaluated (ie JitWatch on the rescue) such abstraction won't
affect the performance of the 2 cases, but if you think that is better to put
everything under a big `if (verbose)` I can understand your reasons too: that's
why having 6 eyes on it is more than wellcome IMO :)
> HdrHistogram support on verbose SyncCalculation
> -----------------------------------------------
>
> Key: ARTEMIS-1476
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1476
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
>
> The SyncCalculation::syncTest could benefit of
> [HdrHistogram|http://hdrhistogram.org/] support to represent the write
> latencies percentile distribution while using it as a CLI command (ie through
> the perf-journal command).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
