[
https://issues.apache.org/jira/browse/ARTEMIS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218235#comment-16218235
]
ASF GitHub Bot commented on ARTEMIS-1476:
-----------------------------------------
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146780491
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/SyncCalculation.java
---
@@ -54,92 +172,94 @@ public static long syncTest(File datafolder,
String fileName,
int maxAIO,
JournalType journalType) throws Exception {
- SequentialFileFactory factory = newFactory(datafolder, fsync,
journalType, blockSize * blocks, maxAIO);
-
+ final Supplier<? extends SyncIOCompletion> ioCallbackFactory;
--- End diff --
> For me trying to understand the code just for a review and understand the
differences/changes right now is a bit hard, as too much has moved, its not
impossible just is making it tricky to be sure.
I think is normal: I've used the spitted view on github and it helps (vs
the unified one), but probably it works just if you already know by heart the
original code. Your review is a good way for me to have a more objective view
of that so I will provide a cleaner separation of the 2 paths as a separate
commit to be squashed if it will pass the reviews (by the end of the day; I've
other stuff to do first :P).
Just for the sake of completeness, I will ask to @clebertsuconic too: he
knows by heart the original code for sure!
@clebertsuconic wdyt about the last implementation? Have you found
difficult to trace/understand how much has changed the not `--verbose` path vs
the original?
> HdrHistogram support on verbose SyncCalculation
> -----------------------------------------------
>
> Key: ARTEMIS-1476
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1476
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
>
> The SyncCalculation::syncTest could benefit of
> [HdrHistogram|http://hdrhistogram.org/] support to represent the write
> latencies percentile distribution while using it as a CLI command (ie through
> the perf-journal command).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
