[
https://issues.apache.org/jira/browse/BEAM-9041?focusedWorklogId=365552&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365552
]
ASF GitHub Bot logged work on BEAM-9041:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/20 00:11
Start Date: 03/Jan/20 00:11
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #10492: [BEAM-9041,
BEAM-9042] SchemaCoder equals should not rely on from/toRowFunction equality
URL: https://github.com/apache/beam/pull/10492
I did this PR with the two fixes for two reasons (1) because one fix
depended on the other, and (2) to make it easier to validate/cherry pick into
2.18.0's branch.
BEAM-9041: Don't rely on equality for the from/to functions in `SchemaCoder`
because nobody implements equals on `SerializableFunction`. I tried to do this
with byte equality, maybe there is a better way to do it but I could not think
of another.
BEAM-9042: Since Avro's `Schema` class is not `Serializable` I made it
`transient`. Another approach could have been to transform the Schema into a
String and include it but so far it does not look necessary since this is a
parameter once the fn is deserialized.
R: @TheNeuralBit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 365552)
Remaining Estimate: 0h
Time Spent: 10m
> SchemaCoder equals should not rely on from/toRowFunction equality
> -----------------------------------------------------------------
>
> Key: BEAM-9041
> URL: https://issues.apache.org/jira/browse/BEAM-9041
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Fix For: 2.18.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> SchemaCoder equals implementation relies on SerializableFunction equals
> method, this is error-prone because users rarely implement the equals method
> for a SerializableFunction. One alternative would be to rely on bytes
> equality for this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
