[
https://issues.apache.org/jira/browse/BEAM-9041?focusedWorklogId=367138&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367138
]
ASF GitHub Bot logged work on BEAM-9041:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/20 00:50
Start Date: 07/Jan/20 00:50
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on issue #10492: [BEAM-9041,
BEAM-9042] SchemaCoder equals should not rely on from/toRowFunction equality
URL: https://github.com/apache/beam/pull/10492#issuecomment-571381848
Sorry revert was a poor choice of words. I just meant a big part of that PR
was making equals work for the functions produced by
GetterBasedSchemaProvider so I would like it if they continued to be used.
For a function without any state I would write the equals function to just
compare this.getClass().equals(other.getClass()) since any two instances
will do the same thing.
On Mon, Jan 6, 2020 at 2:00 PM Ismaël Mejía <[email protected]>
wrote:
> This is not a revert. Previous version did not compare from/toRow
> functions for equality. Do you have any suggestion on how to compare both
> functions? It is not really clear to me how to do so in particular for
> functions with no state.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/10492?email_source=notifications&email_token=AAFEZ3356TFQGYYPMGZ3GJTQ4OSV3A5CNFSM4KCIC5T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIG5ZTI#issuecomment-571333837>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAFEZ3543QDX3QM2FHQIIQ3Q4OSV3ANCNFSM4KCIC5TQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 367138)
Time Spent: 1h (was: 50m)
> SchemaCoder equals should not rely on from/toRowFunction equality
> -----------------------------------------------------------------
>
> Key: BEAM-9041
> URL: https://issues.apache.org/jira/browse/BEAM-9041
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Fix For: 2.18.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> SchemaCoder equals implementation relies on SerializableFunction equals
> method, this is error-prone because users rarely implement the equals method
> for a SerializableFunction. One alternative would be to rely on bytes
> equality for this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
