[ https://issues.apache.org/jira/browse/BEAM-9041?focusedWorklogId=367017&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367017 ]
ASF GitHub Bot logged work on BEAM-9041: ---------------------------------------- Author: ASF GitHub Bot Created on: 06/Jan/20 22:00 Start Date: 06/Jan/20 22:00 Worklog Time Spent: 10m Work Description: iemejia commented on issue #10492: [BEAM-9041, BEAM-9042] SchemaCoder equals should not rely on from/toRowFunction equality URL: https://github.com/apache/beam/pull/10492#issuecomment-571333837 This is not a revert. Previous version did not compare from/toRow functions for equality. Do you have any suggestion on how to compare both functions? It is not really clear to me how to do so in particular for functions with no state. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 367017) Time Spent: 50m (was: 40m) > SchemaCoder equals should not rely on from/toRowFunction equality > ----------------------------------------------------------------- > > Key: BEAM-9041 > URL: https://issues.apache.org/jira/browse/BEAM-9041 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Ismaël Mejía > Assignee: Ismaël Mejía > Priority: Minor > Fix For: 2.18.0 > > Time Spent: 50m > Remaining Estimate: 0h > > SchemaCoder equals implementation relies on SerializableFunction equals > method, this is error-prone because users rarely implement the equals method > for a SerializableFunction. One alternative would be to rely on bytes > equality for this. -- This message was sent by Atlassian Jira (v8.3.4#803005)