[
https://issues.apache.org/jira/browse/BEAM-9041?focusedWorklogId=367178&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367178
]
ASF GitHub Bot logged work on BEAM-9041:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/20 02:36
Start Date: 07/Jan/20 02:36
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #10492: [BEAM-9041,
BEAM-9042] SchemaCoder equals should not rely on from/toRowFunction equality
URL: https://github.com/apache/beam/pull/10492#issuecomment-571406505
Hmm. I am torn on this. I agree with @TheNeuralBit that mostly these
conversions should just own their own `equals`. But I see how
`SerializableFunction`, especially lambdas, will usually not implement this.
In the case of the `SchemaCoder` it is often automated, isn't it? And when
it isn't, it is fair that it is a one-time up front effort to write a slightly
larger class that has a good `equals`. We could provide a convenient base
class, I guess, or even now add a `default` implementation in the functional
interface maybe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 367178)
Time Spent: 1h 10m (was: 1h)
> SchemaCoder equals should not rely on from/toRowFunction equality
> -----------------------------------------------------------------
>
> Key: BEAM-9041
> URL: https://issues.apache.org/jira/browse/BEAM-9041
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Fix For: 2.18.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> SchemaCoder equals implementation relies on SerializableFunction equals
> method, this is error-prone because users rarely implement the equals method
> for a SerializableFunction. One alternative would be to rely on bytes
> equality for this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
