[
https://issues.apache.org/jira/browse/BEAM-9041?focusedWorklogId=367508&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367508
]
ASF GitHub Bot logged work on BEAM-9041:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/20 15:27
Start Date: 07/Jan/20 15:27
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #10492: [BEAM-9041,
BEAM-9042] SchemaCoder equals should not rely on from/toRowFunction equality
URL: https://github.com/apache/beam/pull/10492#issuecomment-571635013
I see the things more clearly now, thanks for the explanation @TheNeuralBit.
I was not aware of the goals of the other PR. I have one question related to
that PR. Why did you use the strict conversion (no widening/narrowing) from/to
row only on the schemaCoder that generates GenericRecords
`AvroUtils#schemaCoder(java.lang.Class<T>)` and not in the others. Or maybe the
real question is why we need to do this strictly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 367508)
Time Spent: 1h 20m (was: 1h 10m)
> SchemaCoder equals should not rely on from/toRowFunction equality
> -----------------------------------------------------------------
>
> Key: BEAM-9041
> URL: https://issues.apache.org/jira/browse/BEAM-9041
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Fix For: 2.18.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> SchemaCoder equals implementation relies on SerializableFunction equals
> method, this is error-prone because users rarely implement the equals method
> for a SerializableFunction. One alternative would be to rely on bytes
> equality for this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
