[
https://issues.apache.org/jira/browse/BEAM-9041?focusedWorklogId=367692&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367692
]
ASF GitHub Bot logged work on BEAM-9041:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/20 19:34
Start Date: 07/Jan/20 19:34
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #10492:
[BEAM-9041, BEAM-9042] SchemaCoder equals should not rely on from/toRowFunction
equality
URL: https://github.com/apache/beam/pull/10492#discussion_r363911955
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaCoder.java
##########
@@ -102,7 +102,8 @@ protected SchemaCoder(
/**
* Returns a {@link SchemaCoder} for the specified class. If no schema is
registered for this
- * class, then throws {@link NoSuchSchemaException}.
+ * class, then throws {@link NoSuchSchemaException}. The parameter functions
to convert from and
+ * to Rows <b>must</b> implement the equals contract.
Review comment:
:+1: thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 367692)
Time Spent: 1h 50m (was: 1h 40m)
> SchemaCoder equals should not rely on from/toRowFunction equality
> -----------------------------------------------------------------
>
> Key: BEAM-9041
> URL: https://issues.apache.org/jira/browse/BEAM-9041
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Fix For: 2.18.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> SchemaCoder equals implementation relies on SerializableFunction equals
> method, this is error-prone because users rarely implement the equals method
> for a SerializableFunction. One alternative would be to rely on bytes
> equality for this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
