[
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269352#comment-15269352
]
ASF GitHub Bot commented on CB-11023:
-------------------------------------
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-216629805
@macdonst @purplecabbage
On my other machine (Mac), I see the same behavior that you both were
seeing. I was able to fix it by doing a `cordova-coho/coho npm-link` and
re-adding the android platform to the project. What was happening was the
cordova-common module inside of cordova-android wasn't being linked to the one
in cordova-lib, so it was using a cordova-common without my changes in it, thus
using the default functionality of config-file.
On a side note (this only happens for me on Mac, works fine on Windows),
when coho replaces the cordova-common module with a symlink, this was treated
as deleting the cordova-common module, then when I go to add the android
platform, I get an error saying `Cannot find module 'cordova-common'` and when
I checked the node modules folder, there's only a symlink file of
cordova-common. I'm not really sure how symlinks are supposed to work on Mac
since I mainly use a Windows machine. The project still runs and cordova-common
is actually linked. I'm not sure if this is a Mac issue or something else.
> plugin.xml should be able to add attribute to an existing element in
> AndroidManifest.xml
> ----------------------------------------------------------------------------------------
>
> Key: CB-11023
> URL: https://issues.apache.org/jira/browse/CB-11023
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI, Plugman
> Reporter: Carlos Santana
>
> We have a need for a plugin we develop to add the attribute android:name to
> the <application> element to be able to point to a Class that tracks app
> sessions for analytics.
> plugin.xml only support via <config-file> only to add elements to
> AndroidManfist.xml this request is to add an enhancement to also handle
> adding an attribute to an existing element.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
