[
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291621#comment-15291621
]
ASF GitHub Bot commented on CB-11023:
-------------------------------------
Github user ktop commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/432#discussion_r63922339
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -116,6 +117,13 @@ function preparePlatforms (platformList, projectRoot,
options) {
var browserify = require('../plugman/browserify');
return browserify(project, platformApi);
}
+ })
+ .then(function () {
+ // Handle config-file in config.xml
+ var platformRoot = path.join(projectRoot, 'platforms',
platform);
+ var platformJson = PlatformJson.load(platformRoot,
platform);
+ var munger = new PlatformMunger(platform, platformRoot,
platformJson);
+ munger.add_config_changes(project.projectConfig,
/*should_increment=*/true).save_all();
--- End diff --
Thanks for reviewing, I'll make the change.
> plugin.xml should be able to add attribute to an existing element in
> AndroidManifest.xml
> ----------------------------------------------------------------------------------------
>
> Key: CB-11023
> URL: https://issues.apache.org/jira/browse/CB-11023
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI, Plugman
> Reporter: Carlos Santana
>
> We have a need for a plugin we develop to add the attribute android:name to
> the <application> element to be able to point to a Class that tracks app
> sessions for analytics.
> plugin.xml only support via <config-file> only to add elements to
> AndroidManfist.xml this request is to add an enhancement to also handle
> adding an attribute to an existing element.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
