[
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290002#comment-15290002
]
ASF GitHub Bot commented on CB-11023:
-------------------------------------
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220179183
@ktop I have a couple questions. First, do we have a plan for dealing with
plugins that have conflicting attribute edits? For example, if plugin A has
this in its plugin.xml:
```xml
<config-file target="AndroidManifest.xml" parent="/manifest" attr="true">
<uses-sdk android:maxSdkVersion="22" />
</config-file>
```
and plugin B has this in its plugin.xml:
```xml
<config-file target="AndroidManifest.xml" parent="/manifest" attr="true">
<uses-sdk android:maxSdkVersion="17" />
</config-file>
```
Will the user get a build error?
Second, is it possible to reference a sibling of the same tag type? For
example, given this in my AndroidManifest.xml:
```xml
<application android:icon="@drawable/icon" android:label="@string/app_name">
<activity
android:label="@string/activity_name"
android:name="MainActivity" />
<activity
android:label="@string/second_activity"
android:name="SecondActivity" />
</application>
```
If I wanted to add an attribute in the second Activity, how would I do so?
This isn't a real-life example, but you get the idea.
> plugin.xml should be able to add attribute to an existing element in
> AndroidManifest.xml
> ----------------------------------------------------------------------------------------
>
> Key: CB-11023
> URL: https://issues.apache.org/jira/browse/CB-11023
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI, Plugman
> Reporter: Carlos Santana
>
> We have a need for a plugin we develop to add the attribute android:name to
> the <application> element to be able to point to a Class that tracks app
> sessions for analytics.
> plugin.xml only support via <config-file> only to add elements to
> AndroidManfist.xml this request is to add an enhancement to also handle
> adding an attribute to an existing element.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
