[
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276920#comment-15276920
]
ASF GitHub Bot commented on CB-11023:
-------------------------------------
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-217972581
@macdonst I've added the implementation for config-file to config.xml just
to get it working, but I do think it should be refactored
(cordova-common/src/ConfigChanges/ConfigChanges.js). I really just wanted to
rename `add_plugin_changes` to something more general but that would mean I
have to do refactoring in several other repos. I'll take some suggestions on
how to refactor, but for now, I just made a similar function that does almost
the same thing, `add_config_changes`.
This config-file will be handled right after platform prepare happens,
which is called on every prepare and plugin install/uninstall. I think this
should handle the case for config.xml overriding plugin.xml.
> plugin.xml should be able to add attribute to an existing element in
> AndroidManifest.xml
> ----------------------------------------------------------------------------------------
>
> Key: CB-11023
> URL: https://issues.apache.org/jira/browse/CB-11023
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI, Plugman
> Reporter: Carlos Santana
>
> We have a need for a plugin we develop to add the attribute android:name to
> the <application> element to be able to point to a Class that tracks app
> sessions for analytics.
> plugin.xml only support via <config-file> only to add elements to
> AndroidManfist.xml this request is to add an enhancement to also handle
> adding an attribute to an existing element.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
