[
https://issues.apache.org/jira/browse/DRILL-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446953#comment-16446953
]
ASF GitHub Bot commented on DRILL-6336:
---------------------------------------
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/drill/pull/1235
DRILL-6336: Inconsistent method name.
Change the method name "append" to "print" since its body code is an method
invocation "writer.print( s )". The method named "print" should be more clear.
The method name "append" is labeled as "@Deprecated" in case of breaking
backward compatibility.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BruceKuiLiu/drill master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1235.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1235
----
commit d501d338f23acd60164d85c36f5143426a426ea3
Author: Kui LIU <brucekuiliu@...>
Date: 2018-04-17T15:45:44Z
Rename method.
----
> Inconsistent method name.
> -------------------------
>
> Key: DRILL-6336
> URL: https://issues.apache.org/jira/browse/DRILL-6336
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: KuiLIU
> Priority: Major
> Attachments: rename-method.patch
>
>
> The following method is named "append", but its body code is an method
> invocation "writer.print( s )". The method should be named "print".
> {code:java}
> public DebugStringBuilder append( String s ) {
> writer.print( s );
> return this;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
