[
https://issues.apache.org/jira/browse/DRILL-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458239#comment-16458239
]
ASF GitHub Bot commented on DRILL-6336:
---------------------------------------
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1235
My take is that "append" is more common for classes with the similar
functionality, see for example `ToStringBuilder`. As there is no added benefit
of using "print" vs "append", my recommendation is to keep "append" as is and
see if `DebugStringBuilder` can be replaced with the `ToStringBuilder`.
> Inconsistent method name.
> -------------------------
>
> Key: DRILL-6336
> URL: https://issues.apache.org/jira/browse/DRILL-6336
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: KuiLIU
> Priority: Major
> Attachments: rename-method.patch
>
>
> The following method is named "append", but its body code is an method
> invocation "writer.print( s )". The method should be named "print".
> {code:java}
> public DebugStringBuilder append( String s ) {
> writer.print( s );
> return this;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
