[
https://issues.apache.org/jira/browse/DRILL-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474347#comment-16474347
]
ASF GitHub Bot commented on DRILL-6336:
---------------------------------------
BruceKuiLiu commented on issue #1235: DRILL-6336: Inconsistent method name.
URL: https://github.com/apache/drill/pull/1235#issuecomment-388855662
The target of this class is to build a debug string for an object.
Change the class name may break this target.
I agree with @vrozov and @paul-rogers. Considering the class is a
_builder_, `append()` should be better than `print()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Inconsistent method name.
> -------------------------
>
> Key: DRILL-6336
> URL: https://issues.apache.org/jira/browse/DRILL-6336
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: KuiLIU
> Priority: Major
> Attachments: rename-method.patch
>
>
> The following method is named "append", but its body code is an method
> invocation "writer.print( s )". The method should be named "print".
> {code:java}
> public DebugStringBuilder append( String s ) {
> writer.print( s );
> return this;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
