[
https://issues.apache.org/jira/browse/DRILL-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474337#comment-16474337
]
ASF GitHub Bot commented on DRILL-6336:
---------------------------------------
BruceKuiLiu closed pull request #1235: DRILL-6336: Inconsistent method name.
URL: https://github.com/apache/drill/pull/1235
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java
b/exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java
index d4ee60ac2f..33b2963263 100644
---
a/exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java
+++
b/exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java
@@ -835,18 +835,18 @@ public boolean isRepeated() {
public String toString() {
DebugStringBuilder buf = new DebugStringBuilder(this);
if (isConstant()) {
- buf.append("const ");
+ buf.print("const ");
}
- buf.append(holder.type().fullName())
- .append(" ")
- .append(holder.name())
- .append(", ")
- .append(type.getMode().name())
- .append(" ")
- .append(type.getMinorType().name())
- .append(", ");
+ buf.print(holder.type().fullName())
+ .print(" ")
+ .print(holder.name())
+ .print(", ")
+ .print(type.getMode().name())
+ .print(" ")
+ .print(type.getMinorType().name())
+ .print(", ");
holder.generate(buf.formatter());
- buf.append(", ");
+ buf.print(", ");
value.generate(buf.formatter());
return buf.toString();
}
diff --git
a/exec/java-exec/src/main/java/org/apache/drill/exec/expr/DebugStringBuilder.java
b/exec/java-exec/src/main/java/org/apache/drill/exec/expr/DebugStringBuilder.java
index a9b0f229b0..01a901aeea 100644
---
a/exec/java-exec/src/main/java/org/apache/drill/exec/expr/DebugStringBuilder.java
+++
b/exec/java-exec/src/main/java/org/apache/drill/exec/expr/DebugStringBuilder.java
@@ -44,7 +44,7 @@ public DebugStringBuilder( Object obj ) {
fmt = new JFormatter( writer );
}
- public DebugStringBuilder append( String s ) {
+ public DebugStringBuilder print( String s ) {
writer.print( s );
return this;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Inconsistent method name.
> -------------------------
>
> Key: DRILL-6336
> URL: https://issues.apache.org/jira/browse/DRILL-6336
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: KuiLIU
> Priority: Major
> Attachments: rename-method.patch
>
>
> The following method is named "append", but its body code is an method
> invocation "writer.print( s )". The method should be named "print".
> {code:java}
> public DebugStringBuilder append( String s ) {
> writer.print( s );
> return this;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
