[
https://issues.apache.org/jira/browse/DRILL-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474338#comment-16474338
]
ASF GitHub Bot commented on DRILL-6336:
---------------------------------------
BruceKuiLiu opened a new pull request #1235: DRILL-6336: Inconsistent method
name.
URL: https://github.com/apache/drill/pull/1235
Change the method name "append" to "print" since its body code is an method
invocation "writer.print( s )". The method named "print" should be more clear.
The method name "append" is labeled as "@Deprecated" in case of breaking
backward compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Inconsistent method name.
> -------------------------
>
> Key: DRILL-6336
> URL: https://issues.apache.org/jira/browse/DRILL-6336
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: KuiLIU
> Priority: Major
> Attachments: rename-method.patch
>
>
> The following method is named "append", but its body code is an method
> invocation "writer.print( s )". The method should be named "print".
> {code:java}
> public DebugStringBuilder append( String s ) {
> writer.print( s );
> return this;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
