ppkarwasz commented on code in PR #4719:
URL: https://github.com/apache/eventmesh/pull/4719#discussion_r1554721707
##########
eventmesh-starter/build.gradle:
##########
@@ -17,4 +17,7 @@
dependencies {
implementation project(":eventmesh-runtime")
-}
\ No newline at end of file
+ // Logging backend
+ runtimeOnly "org.apache.logging.log4j:log4j-core"
+ runtimeOnly "org.apache.logging.log4j:log4j-slf4j2-impl"
Review Comment:
Most `log4j-core` dependencies should be in the `testRuntimeOnly`
configuration, so they are invisible to external projects that use those
`eventmesh-openconnect` artifacts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
