Pil0tXia commented on code in PR #4719:
URL: https://github.com/apache/eventmesh/pull/4719#discussion_r1554837736
##########
build.gradle:
##########
@@ -94,6 +94,33 @@ allprojects {
.exclude('**/org/apache/eventmesh/connector/openfunction/client/CallbackServiceGrpc**')
.exclude('**/org/apache/eventmesh/connector/jdbc/antlr**')
+ configurations {
+ if (!"eventmesh-starter".equals(project.name)) {
+ runtimeClasspath {
+ // Log4j API implementations
+ exclude group: 'org.apache.logging.log4j', module: 'log4j-core'
Review Comment:
`eventmesh-starter` will start `eventmesh-runtime`, and the connectors can
also be started from a command line.
I think external projects should only use `eventmesh-sdk-java` or any other
language of SDKs under `eventmesh-sdks` (which isn't written in java).
`eventmesh-openconnect-api` is less likely to be used in external projects.
Just as I said in
https://github.com/apache/eventmesh/pull/4719#discussion_r1554660695, I may
prefer the latter approach (first introducing logging backends normally in
`eventmesh-common`, then excluding any transitive logging backend from direct
SDK dependencies), because excluding logging backends globally won't resolve
all problems, but also introducing more configurations on a single artifact in
many scattered places, which is not that elegant. What do you think then? ☺️
I really appreciate your thoughts, but I'm sorry that I didn't explain the
various uses of the project to you in the first place, which resulted in the
solution you were trying to implement in the first place not being as elegant
after the modifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
