ppkarwasz commented on code in PR #4719:
URL: https://github.com/apache/eventmesh/pull/4719#discussion_r1555936934
##########
eventmesh-connectors/eventmesh-connector-rocketmq/build.gradle:
##########
@@ -16,21 +16,25 @@
*/
List rocketmq = [
- "org.apache.rocketmq:rocketmq-client:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-broker:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-common:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-store:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-namesrv:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-tools:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-remoting:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-logging:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-srvutil:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-filter:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-acl:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-srvutil:$rocketmq_version",
-
+ "org.apache.rocketmq:rocketmq-client:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-broker:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-common:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-store:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-namesrv:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-tools:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-remoting:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-logging:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-srvutil:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-filter:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-acl:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-srvutil:${rocketmq_version}"
]
+configurations {
+ implementation.exclude group: "ch.qos.logback", module: "logback-classic"
+ implementation.exclude group: "ch.qos.logback", module: "logback-core"
+}
Review Comment:
I did some experiments and the `configuration { runtimeClasspath {} }` block
might prevent the propagation of logging backends in the EventMesh project, but
it is ineffective for third-party projects.
A better alternative would be the [Gradle Enforcer
Plugin](https://kordamp.org/enforcer-gradle-plugin/) configured with a
[`BannedDependencies`](https://kordamp.org/enforcer-gradle-plugin/#_banneddependencies)
rule. Unfortunately I was not able to configure it without triggering the
kordamp/enforcer-gradle-plugin#22 issue.
In the end, I removed the `configurations` block entirely and replaced it
with surgical strikes against broken dependencies (RocketMQ, Pulsar and
Zookeeper). I also excluded `spring-boot-starter-logging` from Spring Boot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
