Pil0tXia commented on code in PR #4719:
URL: https://github.com/apache/eventmesh/pull/4719#discussion_r1554822742
##########
build.gradle:
##########
@@ -139,6 +164,72 @@ allprojects {
}
}
+def log4jVersion = '2.22.1'
+
+configurations {
+ distOnly
+}
+
+dependencies {
+ distOnly "org.apache.logging.log4j:log4j-core:${log4jVersion}"
+ distOnly "org.apache.logging.log4j:log4j-slf4j2-impl:${log4jVersion}"
+}
+
+tasks.register('dist') {
+ group = JavaBasePlugin.BUILD_TASK_NAME
+ description "Creates the distribution directory"
+ def includedProjects =
+ ["eventmesh-common",
+ "eventmesh-meta:eventmesh-meta-api",
+ "eventmesh-metrics-plugin:eventmesh-metrics-api",
+ "eventmesh-protocol-plugin:eventmesh-protocol-api",
+ "eventmesh-retry:eventmesh-retry-api",
+ "eventmesh-runtime",
+ "eventmesh-security-plugin:eventmesh-security-api",
+ "eventmesh-spi",
+ "eventmesh-starter",
+ "eventmesh-storage-plugin:eventmesh-storage-api",
+ "eventmesh-trace-plugin:eventmesh-trace-api",
+ "eventmesh-webhook:eventmesh-webhook-api",
+ "eventmesh-webhook:eventmesh-webhook-admin",
+ "eventmesh-webhook:eventmesh-webhook-receive"]
+ includedProjects.each { dependsOn("${it}:jar") }
+ outputs.dirs('dist/apps', 'dist/bin', 'dist/conf', 'dist/lib',
'dist/licenses')
Review Comment:
`installPlugin` is a seperate task (according to
https://eventmesh.apache.org/docs/instruction/runtime/#24-package-plugins),
which can bring more flexibility in plugin file loading. So I think
`installPlugin` doesn't need to depend on `dist`, and `dist` should depend on
`jar`.
In terms of task scripts, I think there isn't any logic that needs to be
changed, it's better to minimize logic changes ~ the grammar change is totally
ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
