Pil0tXia commented on code in PR #4719:
URL: https://github.com/apache/eventmesh/pull/4719#discussion_r1554823665
##########
eventmesh-starter/build.gradle:
##########
@@ -17,4 +17,7 @@
dependencies {
implementation project(":eventmesh-runtime")
-}
\ No newline at end of file
+ // Logging backend
+ runtimeOnly "org.apache.logging.log4j:log4j-core"
+ runtimeOnly "org.apache.logging.log4j:log4j-slf4j2-impl"
Review Comment:
>it shows that some modules under `eventmesh-openconnect` is depending on it
directly, which can be substituted with `eventmesh-common` denpendency.
What I mean is that `eventmesh-openconnect` should have depended on
`eventmesh-common` to avoid having to manually add dependencies in
`eventmesh-openconnect`. This was an oversight by previous developers.
`eventmesh-openconnect` module should be less likely to be depended on by
third-party applications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
